Re: [Xen-devel] [PATCH RFC/WIP 1/4] Introduce SHUTDOWN_kexec shutdown reason

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.08.14 at 15:42, <vkuznets@xxxxxxxxxx> wrote:
> --- a/xen/include/public/sched.h
> +++ b/xen/include/public/sched.h
> @@ -158,7 +158,8 @@ DEFINE_XEN_GUEST_HANDLE(sched_watchdog_t);
>  #define SHUTDOWN_suspend    2  /* Clean up, save suspend info, kill.         
> */
>  #define SHUTDOWN_crash      3  /* Tell controller we've crashed.             
> */
>  #define SHUTDOWN_watchdog   4  /* Restart because watchdog time expired.     
> */
> -#define SHUTDOWN_MAX        4  /* Maximum valid shutdown reason.             
> */
> +#define SHUTDOWN_kexec      5  /* Soft-reboot for kexec.                     
> */
> +#define SHUTDOWN_MAX        5  /* Maximum valid shutdown reason.             
> */

I have to admit that I dislike the term "kexec" in here as being Linux-
centric (I admit there being a kexec hypercall, but that's intentionally
Linux-centric I would say) - why not SHUTDOWN_soft_reset?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel