Re: [Xen-devel] [PATCH RFC 3/7] xen/arm: Enable the compilation of mem_access and mem_event on ARM.

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Tue, Aug 26, 2014 at 4:38 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 26.08.14 at 16:23, <tamas.lengyel@xxxxxxxxxxxx> wrote:

(looks like you dropped Cc-s)

> On Tue, Aug 26, 2014 at 3:51 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >>> On 22.08.14 at 11:30, <tamas.lengyel@xxxxxxxxxxxx> wrote:

>> > --- a/xen/common/mem_event.c
>> > +++ b/xen/common/mem_event.c
>> > @@ -20,16 +20,19 @@
>> >   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
>> >   */
>> >
>> > -#ifdef CONFIG_X86
>> > -
>> > +#include <xen/sched.h>
>> >  #include <asm/domain.h>
>> >  #include <xen/event.h>
>> >  #include <xen/wait.h>
>> >  #include <asm/p2m.h>
>> >  #include <xen/mem_event.h>
>> >  #include <xen/mem_access.h>
>> > +
>> > +#ifdef CONFIG_X86
>> >  #include <asm/mem_paging.h>
>> >  #include <asm/mem_sharing.h>
>> > +#endif
>>
>> Wouldn't that warrant introduction of HAVE_MEM_SHARING and
>> HAVE_MEM_PAGING?
>
> Can you please elaborate what you mean? I'm not sure how to address this.

We've already got a number of CONFIG_ and HAVE_ manifest
constants (actually I think we use HAVE_* in makefiles and prefer
CONFIG_* in actual sources), which is what I'd prefer here over
explicit use of CONFIG_X86.

Ack.

 

>> > @@ -546,6 +553,7 @@ int mem_event_domctl(struct domain *d,
>> xen_domctl_mem_event_op_t *mec,
>> >              /* Currently only EPT is supported */
>> >              if ( !cpu_has_vmx )
>> >                  break;
>> > +#endif
>>
>> Code like what's getting enclosed in the #ifdef here should really
>> get abstracted out up front.
>>
>
> Can you specify what you mean by "up front"?

In a prereq patch.

Jan

I could move these checks into a separate static inline function in a prereq patch and here just add an empty version for the check for ARM. If that is what you mean.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel