Re: [Xen-devel] [PATCH RFC 3/7] xen/arm: Enable the compilation of mem_access and mem_event on ARM.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.08.14 at 17:21, <tamas.lengyel@xxxxxxxxxxxx> wrote:
> On Tue, Aug 26, 2014 at 4:38 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >>> On 26.08.14 at 16:23, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> > On Tue, Aug 26, 2014 at 3:51 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >> >>> On 22.08.14 at 11:30, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> >> > @@ -546,6 +553,7 @@ int mem_event_domctl(struct domain *d,
>> >> xen_domctl_mem_event_op_t *mec,
>> >> >              /* Currently only EPT is supported */
>> >> >              if ( !cpu_has_vmx )
>> >> >                  break;
>> >> > +#endif
>> >>
>> >> Code like what's getting enclosed in the #ifdef here should really
>> >> get abstracted out up front.
>> >>
>> >
>> > Can you specify what you mean by "up front"?
>>
>> In a prereq patch.
> 
> I could move these checks into a separate static inline function in a
> prereq patch and here just add an empty version for the check for ARM. If
> that is what you mean.

Something along those lines, yes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel