Re: [Xen-devel] [PATCH v8 3/9] vnuma hook to debug-keys u

[Elena Ufimtseva <ufimtseva@xxxxxxxxx>]

On Tue, Aug 26, 2014 at 11:29 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 26.08.14 at 09:45, <ufimtseva@xxxxxxxxx> wrote:
>> @@ -389,6 +389,39 @@ static void dump_numa(unsigned char key)
>>
>>               for_each_online_node(i)
>>                       printk("    Node %u: %u\n", i, page_num_node[i]);
>> +
>> +             if ( d->vnuma )
>> +             {
>> +                     printk("    Domain has %u vnodes, %u vcpus\n",
>> +                                d->vnuma->nr_vnodes, d->max_vcpus);
>> +                     for ( i = 0; i < d->vnuma->nr_vnodes; i++ )
>> +                     {
>> +                             err = snprintf(keyhandler_scratch, 12, "%u",
>> +                                                    
>> d->vnuma->vnode_to_pnode[i]);
>> +                             if ( err < 0 || d->vnuma->vnode_to_pnode[i] == 
>> NUMA_NO_NODE )
>> +                                     snprintf(keyhandler_scratch, 3, "???");
>> +                             printk("        vnode %3u - pnode %s,", i, 
>> keyhandler_scratch);
>> +
>> +                             printk(" %"PRIu64" MB, ",
>> +                                        (d->vnuma->vmemrange[i].end - 
>> d->vnuma->vmemrange[i].start) >> 20);
>> +
>> +                             printk("vcpu nrs: ");
>> +                             for ( j = 0, n = 0; j < d->max_vcpus; j++ )
>> +                             {
>> +                                     if ( d->vnuma->vcpu_to_vnode[j] == i )
>> +                                     {
>> +                                             if ( ((n + 1) % 8) == 0 )
>> +                                                     printk("%d\n", j);
>> +                                             else if ( !(n % 8) && n != 0 )
>> +                                                     printk("%s%d ", "      
>>        ", j);
>> +                                             else
>> +                                                     printk("%d ", j);
>> +                                             n++;
>> +                                     }
>> +                             }
>> +                             printk("\n");
>> +                     }
>> +             }
>>       }
>>
>>       rcu_read_unlock(&domlist_read_lock);
>
> Actually I'm afraid Konrad's comment (and me agreeing to it)
> misguided you here: The function is currently written in Linux
> style, so Linux style is what the changes should be in. I.e.
> opening curly braces on the same line as the end of their
> control construct, and no blanks inside outermost parentheses
> of control constructs.
>
> However, the comment regarding overly long lines was correct
> (and sadly still stands), and there are indentation issues too.
>
> Jan
>

Hi Jan

This file has both coding styles and every my attempt to match it fails :)

Can I make changes to numa.c so it will be formatted like any other
file if there
is no reason to have it formatted in this way?
Also the indentation symbols are different there as well. Re-formatting it will
help me tremendously and maybe others as well.




-- 
Elena

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel