Re: [Xen-devel] [PATCH v8 3/9] vnuma hook to debug-keys u

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.08.14 at 17:36, <ufimtseva@xxxxxxxxx> wrote:
> On Tue, Aug 26, 2014 at 11:29 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> Actually I'm afraid Konrad's comment (and me agreeing to it)
>> misguided you here: The function is currently written in Linux
>> style, so Linux style is what the changes should be in. I.e.
>> opening curly braces on the same line as the end of their
>> control construct, and no blanks inside outermost parentheses
>> of control constructs.
>>
>> However, the comment regarding overly long lines was correct
>> (and sadly still stands), and there are indentation issues too.
> 
> This file has both coding styles and every my attempt to match it fails :)

Not really, its Linux style with perhaps a few mistakes.

> Can I make changes to numa.c so it will be formatted like any other
> file if there
> is no reason to have it formatted in this way?

If you feel up to making it have entirely uniform style, just go for it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel