[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v2 01/12] xen: Relocate mem_access and mem_event into common.



Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:
In preparation to add support for ARM LPAE mem_event, relocate mem_access,
mem_event and auxiliary functions into common Xen code.
This patch makes no functional changes to the X86 side, for ARM mem_event
and mem_access functions are just defined as placeholder stubs, and are
actually enabled later in the series.

Edits that are only header path adjustments:
    xen/arch/x86/domctl.c
    xen/arch/x86/mm/hap/nested_ept.c
    xen/arch/x86/mm/hap/nested_hap.c
    xen/arch/x86/mm/mem_paging.c
    xen/arch/x86/mm/mem_sharing.c
    xen/arch/x86/mm/p2m-pod.c
    xen/arch/x86/mm/p2m-pt.c
    xen/arch/x86/mm/p2m.c
    xen/arch/x86/x86_64/compat/mm.c
    xen/arch/x86/x86_64/mm.c

Makefile adjustments for new/removed code:
    xen/common/Makefile
    xen/arch/x86/mm/Makefile

Relocated prepare_ring_for_helper and destroy_ring_for_helper functions:
    xen/include/xen/mm.h
    xen/common/memory.c
    xen/include/asm-x86/hvm/hvm.h
    xen/arch/x86/hvm/hvm.c

Code movement of mem_event and mem_access with required ifdef wrappers
added to only compile with CONFIG_X86:

As you have created new files. Why not adding a HAS_MEM_ACCESS option (as we did for the device tree and kexec)?

It will avoid most of you "ifdef CONFIG_X86" in common code and compile files only when it required.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.