[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v2 01/12] xen: Relocate mem_access and mem_event into common.




Code movement of mem_event and mem_access with required ifdef wrappers
added to only compile with CONFIG_X86:

As you have created new files. Why not adding a HAS_MEM_ACCESS option (as we did for the device tree and kexec)?

It will avoid most of you "ifdef CONFIG_X86" in common code and compile files only when it required.

Regards,

--
Julien Grall


That would make for a cleaner code for sure, you are right, will switch to that in the next version.
 
Tamas
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.