Xen project Mailing List

Re: [Xen-devel] [PATCH RFC v2 11/12] xen/arm: Enable the compilation of mem_access and mem_event on ARM.

On Wed, Aug 27, 2014 at 5:24 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 27.08.14 at 16:06, <tklengyel@xxxxxxxxxxxxx> wrote:
> --- a/xen/common/mem_event.c
> +++ b/xen/common/mem_event.c
> @@ -20,16 +20,22 @@
> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
>
> -#ifdef CONFIG_X86
> -
> +#include <xen/sched.h>
> #include <asm/domain.h>
> #include <xen/event.h>
> #include <xen/wait.h>
> #include <asm/p2m.h>
> #include <xen/mem_event.h>
> #include <xen/mem_access.h>

This already is quite a mishmash of asm/ and xen/ includes - please
don't make it even worse.

Adding xen/sched.h is required here unfortunately as without it the compilation breaks on ARM:

In file included from /home/odroid/workspace/xen/xen/include/asm/domain.h:6:0,
                 from mem_event.c:23:
/home/odroid/workspace/xen/xen/include/xen/sched.h:251:22: error: field 'arch' has incomplete type
     struct arch_vcpu arch;
                      ^
/home/odroid/workspace/xen/xen/include/xen/sched.h:405:24: error: field 'arch' has incomplete type
     struct arch_domain arch;
                        ^
make[4]: *** [mem_event.o] Error 1

I can put that include into a #ifdef CONFIG_ARM if that helps.

> +
> +#if CONFIG_MEM_PAGING==1

#ifdef please.

Ack.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel