Re: [Xen-devel] [PATCH RFC V8 3/5] xen, libxc: Force-enable relevant MSR events

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.14 at 09:40, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 08/27/2014 11:25 PM, Tian, Kevin wrote:
>>> From: Razvan Cojocaru [mailto:rcojocaru@xxxxxxxxxxxxxxx]
>>> +const u32 vmx_msrs_exit_array[] = {
>>> +    MSR_IA32_SYSENTER_EIP,
>>> +    MSR_IA32_SYSENTER_ESP,
>>> +    MSR_IA32_SYSENTER_CS,
>>> +    MSR_IA32_MC0_CTL,
>>> +    MSR_STAR,
>>> +    MSR_LSTAR
>>> +};
>>> +
>>> +const unsigned int vmx_msrs_exit_array_size =
>>> +    ARRAY_SIZE(vmx_msrs_exit_array);
>>> +
>> 
>> prefer a name including 'force' purpose or at least have a comment
>> to describe the intention, so its meaning is explained as early as possible.
> 
> How would vmx_force_enabled_msrs_array (with a comment added) sound to
> you and Jan?

vmx_introspection_force_enabled_msrs[]?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel