Re: [Xen-devel] [PATCH RFC V8 3/5] xen, libxc: Force-enable relevant MSR events

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Razvan Cojocaru [mailto:rcojocaru@xxxxxxxxxxxxxxx]
> Sent: Thursday, August 28, 2014 12:40 AM
> 
> 
> So if we do a domctl with
> XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE_INTROSPECTION, then we
> must make
> sure that those MSRs are being intercepted (so only then do we call
> hvm_funcs.enable_msr_exit_interception(d)).
> 
> The previous check (the one you've mentioned) only makes sure that if
> d->arch.hvm_domain.introspection_enabled is true, interception for the
> interesting MSRs cannot be disabled.

modularly you don't want a common vmx interface assuming caller's behavior 
but without any check, or you make that interface name introspection specific.

> 
> 
> Thanks,
> Razvan Cojocaru

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel