Re: [Xen-devel] [PATCH 28/46] Use configure --libexecdir=BASEDIR to set LIBEXEC

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-09-23 at 14:34 +0200, Olaf Hering wrote:
> > > -dnl XXX: this should be changed to use the passed $libexec
> > > -dnl but can be done as a second step
> > > -case "$host_os" in
> > > -*netbsd*)  LIBEXEC=$prefix/libexec ;;
> > > -*) LIBEXEC=$prefix/lib/xen/bin ;;
> > > -esac
> > > +if test "x$libexecdir" = 'x${exec_prefix}/libexec' ; then
> > > +    case "$host_os" in
> > > +         *netbsd*)
> > > +         libexecdir=$prefix/libexec
> > > +         ;;
> > > +         *)
> > > +         libexecdir=$prefix/lib
> > > +         ;;
> > > +    esac
> > > +fi
> > 
> > I'm wondering if we should just accept the autoconf default here.
> > Distros which differ from that default (Debian? I thought RPM distros
> > used libexec) are presumably used to passing ---with-libexecdir=.
> 
> At least SUSE uses /usr/lib as libexec.

I stand corrected then.

> So its up to the configure scripts to append "package
> name". I will check what other packages do, but I think my change is
> correct in that part.

Yes I agree, it was the prefix bit I was wondering about.

> Regarding libexec/ vs. lib/: it would change existing behaviour. In the
> end it would most likely not matter because the tools find the binaries
> anyway. Stuff will just end up in different directories. Existing
> domU.cfg files, which refer to a hardcoded path to qemu, hvmloader or
> whatever will need an update. Perhaps the offending line can be removed
> altogether from domU.cfg.
> 
> So if you want, the hunk above can be changed to a plain 
> LIBEXEC=$libexecdir/xen

We certainly shouldn't change it at the same time as this change. If at
all it should be done as a separate change of the default. Perhaps we
should revisit all the places where we deviate from/override the
autoconf defaults after 4.5 instead of doing it now?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel