Re: [Xen-devel] [PATCH v2] xen/arm: check on domain type against hardware support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-29 at 13:28 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 09/29/2014 01:23 PM, Ian Campbell wrote:
> > On Fri, 2014-09-26 at 11:28 +0530, vijay.kilari@xxxxxxxxx wrote:
> >> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> >>
> >> Some arm64 platforms implement only aarch64 mode. So allow
> >> domains that are only 64-bit
> >>
> >> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > I think this is a bug fix so we should take it for 4.5.
> 
> I made a quick comment in response to your answer on V1.

Vijay, based on Julien's comments on v1 I'm inclined to
s/cpu_has_a32/cpu_has_arm/, so we refer to arm+thumb not a32+thumb which
combines to different naming schemes. An alternative would be
s/cpu_has_thumb/cpu_has_t32/ but I don't like that much.

Does that work for you? I can make the trivial change so no need to
resend (unless you want to).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel