[Xen-devel] dead qemu make targets in toplevel Makefile

[Olaf Hering <olaf@xxxxxxxxx>]

Ian,

with commit b0f69ec5c71de1248d915c193b57c43e786857dd ("tools: Make
qemu-xen-traditional build optional.") the existing make targets are
wrapped in ifeq ($(CONF),y), but CONF is never set because
config/Tools.mk is not included. I wonder if that ever worked or if I
just broke it with my changes. But looking at 4.4.1 I dont see how
CONFIG_QEMU_TRAD is set. And in staging QEMU_TRAD_DIR_TGT is also not
used.

Are these make targets useful? I see "git clean -dfx && ./configure &&
make tools/qemu-xen-traditional-dir CONFIG_QEMU_TRAD=y" clones the tree.

Olaf


 72 ifeq ($(CONFIG_QEMU_TRAD),y)
 73 QEMU_TRAD_DIR_TGT := tools/qemu-xen-traditional-dir
 74 
 75 tools/qemu-xen-traditional-dir:
 76         $(MAKE) -C tools qemu-xen-traditional-dir-find
 77 
 78 .PHONY: tools/qemu-xen-traditional-dir-force-update
 79 tools/qemu-xen-traditional-dir-force-update:
 80         $(MAKE) -C tools qemu-xen-traditional-dir-force-update
 81 endif
 82 
 83 ifeq ($(CONFIG_QEMU_XEN),y)
 84 QEMU_XEN_DIR_TGT := tools/qemu-xen-dir
 85 
 86 tools/qemu-xen-dir:
 87         $(MAKE) -C tools qemu-xen-dir-find
 88 
 89 .PHONY: tools/qemu-xen-dir-force-update
 90 tools/qemu-xen-dir-force-update:
 91         $(MAKE) -C tools qemu-xen-dir-force-update
 92 endif


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel