Re: [Xen-devel] [PATCH] tools/hotplug/Linux: Fix build

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Oct 10, 2014 at 01:19:05PM +0200, Olaf Hering wrote:
> On Fri, Oct 10, Anthony PERARD wrote:
> 
> > I think the problem is in tools/Linux/Makefile, where we have:
> > all: subdirs-all
> > install: all subdirs-install
> > 
> > Maybe the "install" rules should depend only on the things it need to
> > install, and not an "all".
> 
> Does removing all fix the failure for you?

Yes, it does, no more weird two calls of make on the systemd/Makefile
(with all and install). There is only one call left: "make -C systemd
install". And make does not fail to make xen.conf.

I've did the test on top of staging, with ian revert commit.

Here is the patch that I have tested:


From 41cfaf5318cb0346e31a8e97939b8805145eb182 Mon Sep 17 00:00:00 2001
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Fri, 10 Oct 2014 12:22:34 +0100
Subject: [PATCH] tools/hotplug/Linux: Removing of "all" dependency from
 "install" rule.

Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

---
 tools/hotplug/Linux/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hotplug/Linux/Makefile b/tools/hotplug/Linux/Makefile
index 8cdaa9a..1706c05 100644
--- a/tools/hotplug/Linux/Makefile
+++ b/tools/hotplug/Linux/Makefile
@@ -43,7 +43,7 @@ all: subdirs-all
 build:
 
 .PHONY: install
-install: all install-initd install-scripts install-udev subdirs-install
+install: install-initd install-scripts install-udev subdirs-install
 
 # See docs/misc/distro_mapping.txt for INITD_DIR location
 .PHONY: install-initd
-- 
Anthony PERARD


-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel