[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH v2 09/12] mfi-common: use XSM build if job name contains -xsm suffix



Wei Liu writes ("[OSSTEST PATCH v2 09/12] mfi-common: use XSM build if job name 
contains -xsm suffix"):
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
...
> +  # Use xsm build job if job contains -xsm suffix
> +  case "$job" in
> +    *-xsm) xenbuildjob="$xenbuildjob-xsm"
> +           buildjob="$buildjob-xsm"
> +           ;;
> +    *) ;;
> +  esac

Please don't try pattern-matching $job like this.  Instead, invent an
extra argument to job_create_test.  Either `buildjobsuffix' applying
to buildjob and xenbuildjob or `xsmsuffix' or perhaps just the
xsm_enable value.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.