Re: [Xen-devel] [PATCH] tools/hotplug/Linux: Fix build

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Oct 10, 2014 at 03:31:10PM +0100, Ian Campbell wrote:
> On Fri, 2014-10-10 at 16:28 +0200, Olaf Hering wrote:
> > On Fri, Oct 10, Anthony PERARD wrote:
> > 
> > > Yes, it does, no more weird two calls of make on the systemd/Makefile
> > > (with all and install). There is only one call left: "make -C systemd
> > > install". And make does not fail to make xen.conf.
> > 
> > I ran into this as well just now, and removing all works for me as well.
> > 
> > > From 41cfaf5318cb0346e31a8e97939b8805145eb182 Mon Sep 17 00:00:00 2001
> > > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > > Date: Fri, 10 Oct 2014 12:22:34 +0100
> > > Subject: [PATCH] tools/hotplug/Linux: Removing of "all" dependency from
> > >  "install" rule.
> > > 
> > > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > 
> > Tested-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> Great. Could someone supply a bit of explanatory text for the commit
> message please.

The "install" rules depends on both "all" and "subdirs-install" and "all"
depends on "subdirs-all". This leads the "install" rules to call both
"subdirs-all" and "subdirs-install" which create a race with two
concurrent `make` within the same directory (systemd) trying to make the
same things (xen.conf) and failing.

Ultimatly, "install" should only depend on the things it needs to
install, and not on "all".

> Do these indicate a similar problem:
> tools/hotplug/NetBSD/Makefile:install: all install-scripts install-rcd
> tools/hotplug/common/Makefile:install: all install-scripts
> ?
> 
> I think not because no recursion is included.

I think this could be an issue, install does not need all. But since
there is no subdirs involves, there is no problem for now.

Shall I update the patch to change all "install" rules of
tools/hotplug/*/Makefile ?

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel