Re: [Xen-devel] [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2014-10-10 at 09:19 +0200, Olaf Hering wrote:
> Use AS_HELP_STRING for proper formating, mention both options take a
> directory, mention the default value, quote the arguments in brackets.
> 
> Please rerun autogen.sh after applying this patch.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked + applied.

> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  m4/systemd.m4 | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/m4/systemd.m4 b/m4/systemd.m4
> index 760bbad..629d202 100644
> --- a/m4/systemd.m4
> +++ b/m4/systemd.m4
> @@ -18,12 +18,16 @@
>  
>  dnl Some optional path options
>  AC_DEFUN([AX_SYSTEMD_OPTIONS], [
> -     AC_ARG_WITH(systemd, [  --with-systemd          set directory for 
> systemd service files],
> -             SYSTEMD_DIR="$withval", SYSTEMD_DIR="")
> +     AC_ARG_WITH(systemd,
> +             AS_HELP_STRING([--with-systemd=DIR],
> +             [set directory for systemd service files 
> [PREFIX/lib/systemd/system]]),
> +             [SYSTEMD_DIR="$withval"],[SYSTEMD_DIR=""])
>       AC_SUBST(SYSTEMD_DIR)
>  
> -     AC_ARG_WITH(systemd, [  --with-systemd-modules-load          set 
> directory for systemd modules load files],
> -             SYSTEMD_MODULES_LOAD="$withval", SYSTEMD_MODULES_LOAD="")
> +     AC_ARG_WITH(systemd,
> +             AS_HELP_STRING([--with-systemd-modules-load=DIR],
> +             [set directory for systemd modules load files 
> [PREFIX/lib/modules-load.d/]]),
> +             [SYSTEMD_MODULES_LOAD="$withval"], [SYSTEMD_MODULES_LOAD=""])
>       AC_SUBST(SYSTEMD_MODULES_LOAD)
>  ])
>  




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel