[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 for 4.5] arm32: fix build after 063188f4b3

>>> On 15.10.14 at 16:13, <julien.grall@xxxxxxxxxx> wrote:
> "xen: arm: Add support for the Exynos secure firmware" introduced code
> assuming that exynos_smc() would get called with arguments in certain
> registers. While the "noinline" attribute guarantees the function to
> not get inlined, it does not guarantee that all arguments arrive in the
> assumed registers: gcc's interprocedural analysis can result in clone
> functions to be created where some of the incoming arguments (commonly
> when they have constant values) get replaced by putting in place the
> respective values inside the clone.
> Xen contains in multiple place of this SMC function: consolidate the 
> function
> in a single place and write it in assembly.
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>

Fwiw, this looks fine to me now (leaving aside the missed spelling
fix you pointed out yourself). For the above tags though, reversing
their order would be preferred (so that their sequence represents
the flow of events).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.