Re: [Xen-devel] [PATCH v6 3/8] xen/arm: return int *_dcache_va_range

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

On 10/16/2014 03:45 PM, Stefano Stabellini wrote:
> These functions cannot really fail on ARM, but their x86 equivalents can
> (-EOPNOTSUPP). Change the prototype to return int.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

I was wondering if we should add a comment in the helpers in case
someone decides to return a non-zero value. If so we will have to check
the return in the caller.

But I guess it will never happen. So either way:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel