[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OPW PATCH V3] tools/xl: Call init function for libxl defined datatypes

On Sun, Oct 19, 2014 at 06:45:11PM +0530, Uma Sharma wrote:
> Actually I looked at the patch sending documentation it stated that if
> some changes are already acknowledged then we have to write it.
> Should I write a new patch with all these changes ? Or I can make the
> changes in different patches?

If someone replies to your patch with a tag of the form "Acked-by:
<Developer>", "Reviewed-by:", "Tested-by:" etc then, assuming you have
not completely reworked the patch, you should include these tags in any
reposting after your own Signed-off-by line.  This lets people know that
the patch has been seen and that someone approves of it and also serves
to prevent reviewers wasting time re-reviewing a patch which is not
significantly different to last time.

An important point of carrying tags is to save reviewers' time, not just
for the sake of carrying.

Your new patch is significantly different to last time, because you've
expanded the scope of your work, which would mean you changes need

A better approach would be to send new patch(es) for your new changes.


> Regards,
> Uma Sharma
> On Sun, Oct 19, 2014 at 6:25 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > On Sun, Oct 19, 2014 at 06:05:01PM +0530, Uma Sharma wrote:
> >> This patch calls init function for libxl_domain_sched_params before
> >> passing it as reference to sched_domain_get() function in
> >> tools/libxl/xl_cmdimpl.c
> >> IDL generated libxl types should be used only after calling the init
> >> function even if the variable is simply being passed by reference as
> >> an output parameter to a libxl function
> >>
> >> Signed-off-by: Uma Sharma <uma.sharma523@xxxxxxxxx>
> >> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >
> > It's confusing that you sent this v3 patch with my ack on it while at
> > the same time changed a bunch of other places.
> >
> > If you have other places to fix, you can send separate patch(es) to fix
> > them. If you want to squash these changes into one patch, then please
> > drop my ack (not that I'm against these changes, just that you've
> > substantially changed the scope of this patch we agreed upon) and write
> > proper change log.
> >
> > Hope the above clarification help you understand the process better, and
> > please don't hesitate to ask any question.
> >
> > Wei.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.