[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OPW PATCH V3] tools/xl: Call init function for libxl defined datatypes

On 10/19/2014 02:15 PM, Uma Sharma wrote:
Actually I looked at the patch sending documentation it stated that if
some changes are already acknowledged then we have to write it.
Should I write a new patch with all these changes ? Or I can make the
changes in different patches?

"Acked-by: Wei Liu <...>" means, "Wei Liu has looked at everything in this patch and doesn't have any objections to it being committed." That way, Ian J can just take a quick look and check it in, trusing Wei's judgement.

But in this case, Wei hasn't looked at the whole patch, but just half of it. So Ian J might end up checking in code that hasn't been reviewed.

Usually, if you change the patch at all (apart from trivial things like whitespace or fixing clear violation of coding conventions) you have to drop the ack.

Since the code you're adding isn't necessarily connected to the code that was already acked, just making a separate patch would have been the best idea in this case.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.