[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] Sanity check xsave area when migrating or restoring from older Xen verions

>>> On 20.10.14 at 14:54, <dkoch@xxxxxxxxxxx> wrote:
> On Sat, 18 Oct 2014 00:36:28 +0100
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 17/10/2014 18:11, Don Koch wrote:
>> > +        for (int i = size; i < desc->length; i++)
>> Style
> Is not really defined for "for". I checked the CODING_STYLE file and it only
> defines style for "if" and "while".

Did you skip the "such as" in the section dealing with them?

> I found more examples of "for" statements
> with no spaces inside the parens; so, I went with that. Will fix.

It's not just about the missing spaces. You also shouldn't declare
variables inside the for() statement.

> Do you want me to update the CODING_STYLES file, too? (In a separate patch,
> of course.)

As hinted at -  the document is sufficient as is afaict.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.