Re: [Xen-devel] [OPW PATCH V2] tools: xl: refactor code to parse network device options

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Oct 21, 2014 at 12:06:41AM +0300, Alexandra Sandulescu wrote:
[...]
> +static int match_option_size(const char *prefix, size_t len,
> +        char *arg, char **argopt)
> +{
> +    int rc = strncmp(prefix, arg, len);
> +    if (!rc) *argopt = arg+len;
> +    return !rc;
> +}
> +#define MATCH_OPTION(prefix, arg, oparg) \
> +    match_option_size((prefix "="), sizeof((prefix)), (arg), &(oparg))
> +
> +static void replace_string(char **str, const char *val)
> +{
> +    free(*str);
> +    *str = strdup(val);
> +}

Could you rebase your patch against staging branch? Dave Scott recently
touched replace_string but that change is yet in master branch.

> +
[...]
> -            fprintf(stderr, "unrecognized argument `%s'\n", *argv);
> -            return 1;
> -        }
> +            if (parse_nic_config(&nic, &config, *argv))
> +            return 1;

Indentation.

Wei.

>      }
>  
>      if (dryrun_only) {
> -- 
> 1.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel