Re: [Xen-devel] [PATCH for 4.5 v7 1/1] Add mmio_hole_size

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 10/21/14 03:46, Jan Beulich wrote:
> > > > On 21.10.14 at 00:01, <dslutz@xxxxxxxxxxx> wrote:
> > On 10/20/14 10:17, Ian Campbell wrote:
> > > > +            /*
> > > > +             * With HVM_BELOW_4G_RAM_END == 0xF0000000, mmio_hole_size
> > > > +             * must be >= 256 MiB and <= 3840 MiB.
> > > Isn't this just restating the if condition in a way which is liable to
> > > get out of sync if the values of HVM_BELOW_4G_* ever changes?
> > Well, Konrad asked for this:
> > [...]
> > So I do not know which way to go here.
> I have to admit that I think Konrad is asking for too much commentary
> now and then. But in any event - Ian being one of the maintainers of
> the affected code, what he asks you to do generally overrules what
> any non-maintainer may have asked for.
Thanks for this.  Sent v8.

    -Don Slutz

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel