[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OPW PATCH V3] tools: xl: refactor code to parse network device options

On Tue, Oct 21, 2014 at 05:19:35PM +0300, Alexandra Sandulescu wrote:
> From: Alexandra Sandulescu <alexandra.sandulescu1@xxxxxxxx>
> This patch removes duplicate code in /tools/libxl/xl_cmdimpl.c by
> adding parse_nic_config function. This function parses configuration
> data and adds the information into libxl_device_nic struct. It is
> called in both main_networkattach and parse_config_data functions
> to replace duplicate code.
> Signed-off-by: Alexandra Sandulescu <alecsandra.sandulescu@xxxxxxxxx>
> ---
>  tools/libxl/xl_cmdimpl.c | 188 
> ++++++++++++++++++-----------------------------
>  1 file changed, 71 insertions(+), 117 deletions(-)
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index ea43761..31a0dcb 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -903,6 +903,74 @@ static void replace_string(char **str, const char *val)
>      *str = xstrdup(val);
>  }
> +/* for now used only by main_networkattach, but can be reused elsewhere */

A minor nit is that you should remove this comment because it is not
true anymore.

Other than that:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

(CC'ing Konrad for his input as release manager)

Now we are in freeze, not sure how applicable is it for this patch to go

To Konrad:

-ve: this is only code refactoring, not bug fix
+ve: the risk of introducing bug is low as 1) this refactoring is
     straight-forward, 2) the code path is tested in OSSTest.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.