[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] Sanity check xsave area when migrating or restoring from older Xen verions

>>> On 21.10.14 at 17:15, <dkoch@xxxxxxxxxxx> wrote:
> The one anomaly I've wondered about is the point of
> ctxt->xfeature_mask; we save it but never use it (outside of a print
> statement) on restore. Do we want to compare it against the global
> xfeature_mask for sanity (print a warning on mismatch) or just ignore
> it. I wouldn't suggest removing it as it would cause another
> compatibility issue with migration.

This was discussed before, and you could also turn to the commit
which eliminated its use to understand why (e2e45c5628
"x86/xsave: remove xfeat_mask checking from validate_xstate()").
And yes, eliminating the _field_ is not an option.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.