Re: [Xen-devel] [PATCH v2] xen/smp: Use die_complete completion when taking CPU down

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 10/22/2014 11:37 AM, H. Peter Anvin wrote:
> On 10/16/2014 09:47 AM, Boris Ostrovsky wrote:
> > diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
> > index 8cd27e0..a78c509 100644
> > --- a/arch/x86/include/asm/smp.h
> > +++ b/arch/x86/include/asm/smp.h
> > @@ -149,7 +149,11 @@ static inline void arch_send_call_function_ipi_mask(const 
> > struct cpumask *mask)
> >         smp_ops.send_call_func_ipi(mask);
> >   }
> >   
> > +#ifdef CONFIG_HOTPLUG_CPU
> >   void cpu_disable_common(void);
> > +void cpu_die_common(unsigned int cpu);
> > +void play_dead_common(void);
> > +#endif
> We generally don't #ifdef prototypes unless they are inlines or macros
> in the unconfiged case.
OK, I'll resend with these ifdefs removed.

Thanks.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel