[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 for-xen-4.5 2/2] dpci: Replace tasklet with an softirq (v8)

>>> On 25.10.14 at 02:39, <konrad.wilk@xxxxxxxxxx> wrote:
> We can stick the 'quisce' part at the end of 'pt_pirq_destroy_bind' or
> at the start of 'pt_irq_create_bind'. And the only way I can think of doing
> this quisce is:
>      if ( pt_pirq_softirq_active(pirq_dpci) )
>      {
>          spin_unlock(&d->event_lock);
> -        ASSERT_NOT_IN_ATOMIC();
> -        process_pending_softirqs();
> +        cpu_relax();
>          goto restart;
>      }
> Which would replicate what a 'tasklet_kill' does.

Ah, right, it was you who added the process_pending_softirqs()
despite tasklet_kill() not having it. With the comment referring to
tasklet_kill()'s behavior I think this is fine to be done as you
suggest above.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.