[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 for-xen-4.5 2/2] dpci: Replace tasklet with an softirq (v8)



>>> On 27.10.14 at 11:40, <andrew.cooper3@xxxxxxxxxx> wrote:
> The domctl lock is a hot lock, and looping with it held like this will
> further starve other toolstack operations.

The domctl lock normally shouldn't be a hot one. It only is if some tool
stack component permanently issues domctl-s to obtain information on
the state of the system. I think it wasn't so long ago that I said I
consider this bad behavior of the tool stack...

> What is the likelihood that this loop will actually be used?  I am
> guessing fairly rare, although it looks more likely to happen for an
> interrupt which is firing frequently?

I think it doesn't so much matter whether the loop will be used
than how long it could end up spinning if used. And that shouldn't
be long, considering that it only waits for interrupt handling to get
finished.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.