[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC PATCH v3 07/12] arch/arm: create device tree nodes for hwdom cpufreq cpu driver
On Mon, Oct 27, 2014 at 3:15 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote: > Hi Oleksandr, > > On 10/27/2014 10:52 AM, Oleksandr Dmytryshyn wrote: >> On Fri, Oct 24, 2014 at 1:24 PM, Oleksandr Dmytryshyn >> <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx> wrote: >>> On Thu, Oct 23, 2014 at 6:49 PM, Julien Grall <julien.grall@xxxxxxxxxx> >>> wrote: >>>>> + >>>>> + DPRINT("Copy %s node to the pcpus\n", node_name); >>>>> + >>>>> + res = fdt_begin_node(fdt, node_name); >>>>> + if ( res ) >>>>> + return res; >>>>> + >>>>> + dt_for_each_property_node( npcpu, pp ) >>>>> + { >>>>> + if ( pp->length ) >>>>> + { >>>>> + res = fdt_property(fdt, pp->name, pp->value, >>>>> + pp->length); >>>>> + if ( res ) >>>>> + return res; >>>>> + } >>>>> + } >>>>> + >>>> >>>> You can use write_properties to replace this loop. >>> I'll try to do this in the next patch set. >> It is better to keep this loop because write_properties() replaces only loop >> and this function contains additional checkings. > > Those checking are only for the "chosen" node. This function is used in > place where we have to copy properties in DOM0 DT. Not sure why you > think it would not fit here? > > BTW, we plan to rework this function for Xen 4.6. The function will > likely look like to your open loop. > >> Also this function passes >> kernel_info * parameter which is absent in the function >> make_hypervisor_node(). >> kinfo->fdt is passed as the parameter to the the function >> make_hypervisor_node(). > > The prototype of make_hypervisor_node is not set in stone :). > It's perfectly fine to pass kinfo in parameter. OK. I'll use this function to replace the loop. > Regards, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |