[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: Disable REP MOVSD optimization if introspection is active

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Mon, 27 Oct 2014 15:33:44 +0200
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, keir@xxxxxxx, xen-devel@xxxxxxxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Mon, 27 Oct 2014 13:33:32 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=cItNjMEmG1MELR2EiQmHKWqoyjlwOA6eKh4MphAuIe8+kF2KJL4zOscILYhLxmf1V9KrEGVfnMr6F+LVaAMhA0RSnSoD7PHAF5PuZZw73gOh8wLrL70/k6up73eZyU3sFjlzembYe8b2sLEVnUT90GUgjI4zeoI3JzruL0yZUawdWaAZNtXENkYTAPQSdyO0vO/oCHnK/jPlr4dfrAXbPLXcBuVQ2YAhWRjtg3amgAL67A/Ebb5x+tWARuAW47QwCpsXhwld3WbxlFDasg9fm0ebTzTVsi4wbER+j8F0DdrLtaZWJxXt+gZ1wrK40FtCjEuB/hS8b4WahMxKxbUOQg==; h=Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 10/27/2014 03:01 PM, Jan Beulich wrote:
>>>> On 27.10.14 at 12:09, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>> If you feel that the patch is acceptable, I'll correct the description
>> when submitting V2.
> I think it's not unreasonable conceptually, but I somewhat doubt the
> place you put the change is the right one. For one it only covers
> "rep movs", but not "rep ins" or "rep outs", and then even non-rep
> memory access may be broken up (due to the 8 byte limit of the
> channel to qemu). For me (lacking sufficient mem-event knowledge)
> it is quite hard to tell whether your change perhaps should be near
> the actual generation of the mem-event (simply because I can't -
> without spending more time than I have for this - right now see
> where exactly that event gets generated). Perhaps
> hvmemul_virtual_to_linear() should be made force *reps to 1 in
> that case instead of making various functions return failure?

Thank you, that's certainly a more elegant way to handle it than my
hack. I'll test it with reps set to 1 in hvmemul_virtual_to_linear(),
and if all goes well and there are no objections to this way of handling
it, will submit a new patch.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.