Re: [Xen-devel] xl: libxl_domain_info: getting domain info list: Bad address

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-09-11 at 16:34 +0100, Ian Jackson wrote:
> From 29e08dfa3a5c5a5aeb51fd01c67345e20cbb33c5 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Date: Fri, 11 Sep 2015 16:27:08 +0100
> Subject: [OSSTEST PATCH] cs-bisection-step: Cope with graph-out (testids)
>  containing ( ) etc.
> 
> cr-try-bisect launders / in the testid but relies on other characters
> being handled appropriately by cs-bisection-step.  So for example it
> can pass
> 
>   graph-out=/home/logs/results/bisect/linux-linus/test-armhf-armhf-xl
> -arndale.leak-check--basis(8)
> 
> But cs-bisection step foolishly assumed that the --graph-out argument
> did not contain any shell metacharacters.  Fix this.
> 
> Specifically:
> 
>  * Change invocations of perl's open to use the 3-argument form
>  * Change invocations of system to pass individual arguments rather
>    than constructing a shell script fragment and relying on the shell
>    to split it up.
>  * In particular, in the png processing pipeline, use the "sh -ec
>    <script> x <arg>..."  technique to pass the input and output
>    filenames in a way that does not expose them to the shell's parser.
>    To avoid making this code more tangled than it already is, also
>    break out the construction of what is now $scriptlet.
>  * Escape metacharacters in the URIs we put in the html output.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel