Re: [Xen-devel] [PATCH v7 05/17] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.09.15 at 03:02, <feng.wu@xxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: Tuesday, September 22, 2015 10:20 PM
>> >>> On 11.09.15 at 10:28, <feng.wu@xxxxxxxxx> wrote:
>> > --- a/xen/include/asm-x86/hvm/vmx/vmcs.h
>> > +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h
>> > @@ -80,8 +80,18 @@ struct vmx_domain {
>> >
>> >  struct pi_desc {
>> >      DECLARE_BITMAP(pir, NR_VECTORS);
>> > -    u32 control;
>> > -    u32 rsvd[7];
>> > +    union {
>> > +        struct {
>> > +        u16     on     : 1,  /* bit 256 - Outstanding Notification */
>> > +                sn     : 1,  /* bit 257 - Suppress Notification */
>> > +                rsvd_1 : 14; /* bit 271:258 - Reserved */
>> > +        u8      nv;          /* bit 279:272 - Notification Vector */
>> > +        u8      rsvd_2;      /* bit 287:280 - Reserved */
>> > +        u32     ndst;        /* bit 319:288 - Notification Destination
>> */
>> > +        };
>> 
>> Clearly the body of the structure is still mis-indented.
> 
> Seeing from the code, this structure is well indented. where do you
> think it has problem?

I'm not sure what "seeing from the code" is supposed to mean, but
I already said where the problem is: The body of a structure (or
union or enum) needs to be indented one level (four space) more
than the line with the struct (or union or enum) keyword, as btw is
being done correctly above for the union containing the struct.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel