Re: [Xen-devel] [PATCH XEN v5 13/23] tools: Refactor foreign memory mapping into libxenforeignmemory

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
[snip]
> > C99 was 16 years ago now, I'm struggling to think of a reason not to move
> > the baseline for tools stuff at least to that.
> >
> > https://en.wikipedia.org/wiki/Visual_C%2B%2B might be one such reason I
> > suppose, although I'm not convinced a libvchan port to Windows, even if
> not
> > entirely hypothetical, would be using any of xen.git/tools/libs/* rather
> > than the equivalent frameworks provided by the Windows PV drivers.
> 
> It would be nice to at least be able to use the same header files, for
> ease of porting userspace software.
> 

It's possible that libvchan on Windows will make use of the tools/libs headers. 
As Andy says it would ease porting client software.

> In this case, VLAs are just being used as an aid for the compiler to
> spot errors.  It doesn't change the API/ABI, and could be #ifdef'd
> around, if we care both for using C99 in general, and Windows support.
> 

We still compile with VS2012 in Citrix and Xen Project uses VS2013 so we can't 
rely on C99. A #ifdef here does seem like the best solution.

  Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel