Re: [Xen-devel] [PATCH 2/2] build: convert NR_CPUS to Kconfig

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Mon, 2016-01-11 at 08:30 -0700, Jan Beulich wrote:
> > > > On 11.01.16 at 16:06, <cardoe@xxxxxxxxxx> wrote:
> > On 1/11/16 8:24 AM, Jan Beulich wrote:
> > > Considering the size of the patch, the doubling of the
> > > identifier's
> > > length, and the fact that even Linux continues to use NR_CPUS
> > > I wonder whether we wouldn't be better of simply having
> > > 
> > > #define NR_CPUS CONFIG_NR_CPUS
> > 
> > Is that a "please do this for a v2" or "what do the other
> > maintainers
> > think?" statement?
> 
> More the former, unless the latter gets answered by "no, this is a
> bad idea".
> 
FWIW, I like Jan's idea and, although not too big of a deal, I'd be
happy to still have the shorter identifier (NR_CPUS) available in
sched_credit2.c

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel