Re: [Xen-devel] [PATCH net-next v2] xen-netback: implement dynamic multicast control

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@xxxxxxxxxx]
> Sent: 02 February 2016 11:54
> To: Paul Durrant; Wei Liu
> Cc: netdev@xxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next v2] xen-netback: implement dynamic multicast
> control
> 
> On Tue, 2016-02-02 at 11:48 +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > > From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> > > Sent: 02 February 2016 11:47
> > > To: Paul Durrant
> > > Cc: netdev@xxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx; Ian
> > > Campbell;
> > > Wei Liu
> > > Subject: Re: [PATCH net-next v2] xen-netback: implement dynamic
> > > multicast
> > > control
> > >
> > > On Tue, Feb 02, 2016 at 11:31:08AM +0000, Paul Durrant wrote:
> > > [...]
> > > > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev,
> > > > +                                       Âstruct xenvif *vif)
> > > > +{
> > > > +       int err = 0;
> > > > +       char *node;
> > > > +       unsigned maxlen = strlen(dev->otherend) +
> > > > +               sizeof("/request-multicast-control");
> > > > +
> > > > +       if (vif->mcast_ctrl_watch.node)
> > > > +               return -EADDRINUSE;
> > > > +
> > >
> > > Sorry if I didn't make myself clear enough. I think EADDRINUSE should
> > > also be logged.
> > >
> >
> > Ok. Not sure how much noise that will cause though.
> 
> If this is a guest trigerable path then don't forget to use the
> ratelimiting printk options....
> 

I *think* it is essentially an error path (i.e should not happen) and the 
function is only called when connecting backend and frontend, which is fairly 
well rate-limited by other things, but I'll stick a rate-limit in there just in 
case.

  Paul

> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel