Re: [Xen-devel] [PATCH V9 1/5] x86/hvm: pkeys, disable pkeys for guests in non-paging mode

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.02.16 at 16:54, <huaitong.han@xxxxxxxxx> wrote:
> On Wed, 2016-02-03 at 08:19 -0700, Jan Beulich wrote:
>> > > > On 03.02.16 at 15:12, <huaitong.han@xxxxxxxxx> wrote:
>> > This patch disables pkeys for guest in non-paging mode, However XEN
>> > always 
>> > uses
>> > paging mode to emulate guest non-paging mode, To emulate this
>> > behavior, pkeys
>> > needs to be manually disabled when guest switches to non-paging
>> > mode.
>> > 
>> > Signed-off-by: Huaitong Han <huaitong.han@xxxxxxxxx>
>> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> 
>> So I had been about to commit the first four patches of this
>> series earlier today, when I noticed the missing VMX maintainers'
>> ack here. You not Cc-ing them of course doesn't help progress.
> The first five version patches does Cc VMX maintainers, the patch is so
> simple that it does receive no comments. Because the CC-list is too
> long and it has reviewed-by Andrew, so...I should always Cc them.

Part of your problem is that you Cc everyone on every patch.
Instead you should vary the Cc lists depending on the code each
individual patch touches.

As to "so simple" - I don't think you can waive the need for an
ack on that basis (at best it would be the committer to decide
we can do without).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel