Re: [Xen-devel] [PATCH 0/9] xen: build fixes with gcc5 and binutils 2.25.0

["Luis R. Rodriguez" <mcgrof@xxxxxxxx>]

On Mon, Feb 08, 2016 at 09:58:23AM +0000, Ian Campbell wrote:
> On Fri, 2016-02-05 at 17:48 -0800, Luis R. Rodriguez wrote:
> > What's up folks? How can this process be made smoother, did I do
> > something wrong, what can I do to help better?
> 
> When you first sent this series to Jan + me not copying the list you were
> asked to send to the list _and_ to CC the appropriate maintainers.

Yeah I truly fat fingered that first series.

> When you resent you only added the xen-devel CC without adjusting the CC.
> Jan pointed this out to you (as a subsequent reply to the original private
> thread) and so I archived both threads in anticipation of a corrected
> series being resent in the not to distant future.

OK I messed up then. My bad, I though this series was posted properly and
failed to note that as the reply was in private and archived, and since
I was busy such fixes weren't posted again. Sorry for the noise.

> CCing maintainers is part of the Xen workflow just as it is with Linux, I
> don't think you would expect to send a random selection of e.g. arch/x86
> and drivers/net fixes to Linus+GregKH and have anything useful happen to
> them.

That's right.

> If you were a newbie to this sort of thing I would probably have kept a
> closer eye out for a v3 and given you some guidance if it didn't
> materialise in a week or two but I didn't think it would be necessary in
> your case since I know you are familiar with this sort of thing from the
> Linux world and your previous contributions to Xen.

No you're right, this just fell through the cracks. The surprising case of
things still being broken on modern tools however should raise a bit of
concern either by opensuse factory folks or by Xen build folks in general.
The issues with required target platfroms to build and if developers are
required to backport features for tools carried / forked is also a pretty
important and IMHO a heavy requirement.

> FWIW I would also suggest sending fixes to different components (qemu-xen,
> qemu-xentraditional, xen.git, mini-os.git) as different series, lest
> someone read patch #1 and assume the whole series is against that component
> rather than something they maintain.

OK thanks. Right Jan didn't read that cover letter so he was not ware of
the work I put into vetting if things were upstream or not.

> And BTW when we say to copy the maintainers we mean the person/people
> responsible for the component in Xen, not the upstream maintainers, e.g.
> Stefano for qemu-xen not Peter Maydell. The xen.git MAINTAINERS file lists
> the right people.

Sure, I do both though, first real upstream and then prod the Xen maintainers.
I take it scripts/get_maintainer.pl should work though? I tried it in a few
patches and it seemed to have worked

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel