[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] libxc: fix leak in xc_offline_page error path

Harmandeep Kaur writes ("[PATCH v2] libxc: fix leak in xc_offline_page error 
> Avoid leaking the mapping of the m2p in one of the possible failure cases.
> Coverity CID 1351225
> Signed-off-by: Harmandeep Kaur <write.harmandeep@xxxxxxxxx>


Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

It is conventional, when you post a v2, to include the
still-applicable formal review tags.

Sometimes it is a matter of judgement, to decide whether an Acked-by
or Reviewed-by, still stands.  But in this case Dario said:

  The code looks ok to me, so, with or without the subject/changelog
  Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

So, he has clearly indicated that your revised version should be

  Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

You would put that right after the Reviewed-by.

However, there is no need to resend your patch for this.  It is normal
for a committer to search the thread for acks to the patch which
arrive after it was posted, and fold them in.

In this case since the Subject has changed, someone needs to make sure
that that search turns up the review, but this message of mine will
serve that purpose.

So, having said all that, thanks for your contribution :-).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.