[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] libxc: fix leak in xc_offline_page error path

On Wed, 2016-02-10 at 11:51 +0000, Ian Jackson wrote:
> Harmandeep Kaur writes ("[PATCH v2] libxc: fix leak in xc_offline_page
> error path"):
> > Avoid leaking the mapping of the m2p in one of the possible failure
> > cases.
> > 
> > Coverity CID 1351225
> > 
> > Signed-off-by: Harmandeep Kaur <write.harmandeep@xxxxxxxxx>
> Thanks.
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

applied, including...

> Â Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> You would put that right after the Reviewed-by.


FTR I was unsure ifÂxc_unmap_domain_meminfo would be safe to call after a
failedÂxc_map_domain_meminfo (which it should be, but with libxc you never
can tell) and I think it is indeed safe, although the failure paths in
xc_map_domain_meminfo are pretty complicated they do appear to always reset
fields in the struct to the "free" state.

> However, there is no need to resend your patch for this.ÂÂIt is normal
> for a committer to search the thread for acks to the patch which
> arrive after it was posted, and fold them in.
> In this case since the Subject has changed, someone needs to make sure
> that that search turns up the review, but this message of mine will
> serve that purpose.
> So, having said all that, thanks for your contribution :-).
> Regards,
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.