[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
- Date: Fri, 12 Feb 2016 08:05:55 +0200
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Delivery-date: Fri, 12 Feb 2016 06:06:17 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=vqhkrO7/n7BGaJEBKsPVp2SY/EBjA+I2BRDMqiuAv8dn28+VMZzRt/Q3fYdt9+Qv78xKUZjkT5/3jwHqVFkW3DWNNvywU2ivSMw9HkmeRZPD+O8XN4UBkfqn9QGY2V4SDZCJ49Pkcu6gDSqHm2dTZpo1sZBTIvqq4UEkpDp7rpNfUcsYVBwS1c+sjbBx4HcqIlwGGQqjkGM0OSDynXO2WIXPAOFcth3f7uJGNhaNdwJs+NpA5mMw2uxP9ydHJSXpI6oIdtxbV349CEZpVfTv0V5XYsR507Hl0XbXug0eyXnStKIp57IxP2nQopYnTc3HYbEX0ZRU9UrVeGXiHekRDg==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
|
On 2/11/2016 5:44 PM, Tamas K Lengyel
wrote:
Point is, they *are* implemented, because that's *common* code, it
doesn't make sense to be moved to the arch-side
when you know that their implementation will be *the same* from
arch-to-arch.
Not *everything* needs to stay on the arch-side, just what is
architecture-specific - that's why e.g. arch_hvm_event_fill_regs,
arch_hvm_event_gfn_of_ip are not in common and are static inline
functions as you say, because they have *different*
implementations *depending on the architecture*.
Finally, if Ian or any other ARM maintainer feels the same with
moving code that can be moved and has been moved to common
back on the arch-side (effectively undoing 50% of my efforts), I
will do so.
Corneliu.
|
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
