Re: [Xen-devel] [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Feb 12, 2016 at 11:04:34AM +0200, Razvan Cojocaru wrote:
> xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate()
> are currently no-ops, that is all they do is set a flag that
> nobody else checks. The user can already set the EMULATE flags in
> the vm_event response if emulation is desired, and having an extra
> check above that is not inherently safer, but it does complicate
> (currenly unnecessarily) the API. This patch removes these
> functions and the corresponding hypervisor code.
> 
> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> ---
>  tools/libxc/include/xenctrl.h | 11 -----------
>  tools/libxc/xc_mem_access.c   | 24 ------------------------

The changes to libxc look good to me.

I'm waiting for v2 to actually ack it.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel