Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.02.16 at 12:37, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Thu, 11 Feb 2016, Konrad Rzeszutek Wilk wrote:
>> --- a/xen/include/xen/keyhandler.h
>> +++ b/xen/include/xen/keyhandler.h
>> @@ -19,6 +19,7 @@
>>   */
>>  typedef void (keyhandler_fn_t)(unsigned char key);
>>  
>> +struct cpu_user_regs;
>>  /*
>>   * Callback type for irq_keyhandler.
>>   *
> 
> I think that the right fix would be to #include <asm/processor.h>.

I disagree - for one this isn't where the structure gets defined,
and then this is the "include everything everywhere" attitude
which tends to needlessly slow down builds (avoiding the need
to include everything everywhere is actually one of the
purposes of such forward declarations, which allows going as
far as having the full definition in just a single source file).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel