Re: [Xen-devel] [PATCH] libxl: close fd's in parent when spawning qdisk

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Feb 16, 2016 at 11:49:53AM +0000, Ian Campbell wrote:
> Coverity points out that these remain open in the parent upon
> success, which is a resource leak.
> 
> To fix this rejig the exit paths such that success and error cases
> both close the two fds, this means adjusting the callback to only
> happen for the error case and it also makes sense to rename the label
> from "error" to just "out".
> 
> Compile tested only.
> 
> CID: 1130518 (null) and 1130517 (logfile_w).
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel