Re: [Xen-devel] [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Thu, Feb 18, 2016 at 11:35:52AM +0100, Juergen Gross wrote:
> On 18/02/16 11:30, Daniel Kiper wrote:
> > On Wed, Feb 17, 2016 at 06:19:30PM +0100, Juergen Gross wrote:
> >> Various features and parameters of a pv-kernel are specified via
> >> elf notes in the kernel image. Those notes are part of the interface
> >> between the Xen hypervisor and the kernel.
> >>
> >> Instead of using num,bers in the code when interpreting the elf notes
> >> make use of the header supplied by Xen for that purpose.
> >>
> >> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> >
> > Yummy! Just one nitpick.
> >
> > Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> >
> >> ---
> >>  grub-core/loader/i386/xen_fileXX.c |  19 +--
> >>  include/xen/elfnote.h              | 281 
> >> +++++++++++++++++++++++++++++++++++++
> >>  2 files changed, 291 insertions(+), 9 deletions(-)
> >>  create mode 100644 include/xen/elfnote.h

[...]

> >> +/*
> >> + * Local variables:
> >> + * mode: C
> >> + * c-file-style: "BSD"
> >> + * c-basic-offset: 4
> >> + * tab-width: 4
> >> + * indent-tabs-mode: nil
> >> + * End:
> >> + */
> >
> > I am not sure that Emacs footer should be copied to GRUB2 source.
>
> Other xen include files contain it, too.

If maintainer do not complain I will do not object.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel