Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote:
> On 18/02/16 11:22, Daniel Kiper wrote:
> > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote:
> >> The loader for xen paravirtualized environment is using lots of global
> >> variables. Reduce the number by making them either local or by putting
> >> them into a single state structure.
> >>
> >> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> >
> > Just two nitpicks but in general...
> >
> > Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> >
> >> ---
> >>  grub-core/loader/i386/xen.c | 259 
> >> +++++++++++++++++++++++---------------------
> >>  1 file changed, 138 insertions(+), 121 deletions(-)

[...]

> >> -  if (!xen_module_info_page)
> >> +  if (!xen_state.module_info_page)
> >>      {
> >> -      n_modules = 0;
> >> -      max_addr = ALIGN_UP (max_addr, PAGE_SIZE);
> >> -      modules_target_start = max_addr;
> >> -      next_start.mod_start = max_addr + xen_inf.virt_base;
> >> -      next_start.flags |= SIF_MULTIBOOT_MOD;
> >> +      xen_state.n_modules = 0;
> >> +      xen_state.max_addr = ALIGN_UP (xen_state.max_addr, PAGE_SIZE);
> >> +      xen_state.modules_target_start = xen_state.max_addr;
> >> +      xen_state.next_start.mod_start =
> >> +  xen_state.max_addr + xen_state.xen_inf.virt_base;
> >
> > Lost one space.
>
> Really? Common indentation style seams to be to use tabs where possible.
> And this is a tab.

Sorry, I have missed that.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel