[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 19/23] xsplice, symbols: Implement symbol name resolution on address. (v2)



On 02/12/2016 06:05 PM, Konrad Rzeszutek Wilk wrote:
snip
  static int load_payload_data(struct payload *payload, uint8_t *raw, ssize_t 
len)
  {
      struct xsplice_elf elf;
@@ -831,6 +953,10 @@ static int load_payload_data(struct payload *payload, 
uint8_t *raw, ssize_t len)
      if ( rc )
          goto err_payload;

+    rc = build_symbol_table(payload, &elf);
+    if ( rc )
+        goto err_payload;
+
      rc = find_special_sections(payload, &elf);
      if ( rc )
          goto err_payload;
@@ -1234,6 +1360,31 @@ unsigned long search_module_extables(unsigned long addr)
  }
  #endif


build_symbol_table() needs to go after find_special_sections() because it uses payload->nfuncs which is only calculated in find_special_sections(). Why did you reorder it from how I did it?

--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.