Re: [Xen-devel] [PATCH v3 07/23] xsplice: Implement support for applying/reverting/replacing patches. (v5)

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> 
> Also above, you've got:
> list_for_each_entry_safe_reverse ( data, tmp, &applied_list, list )
> 
> but it needs to be:
> list_for_each_entry_safe_reverse ( data, tmp, &applied_list, applied_list )

Totally mised it.
> 
> I'm not sure why this was changed from how I had it...

I had issues applying the patch so I modified it by hand - which
was of course the wrong thing to do. Let me also document
that we MUST use the 'applied_list' list.
> 
> rc is also used uninitialized in the replace path.
> 
> -- 
> Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel