Re: [Xen-devel] [PATCH v2 1/8] xen/lockprof: Move .lockprofile.data into .rodata

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.16 at 17:31, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -65,6 +65,12 @@ SECTIONS
>  
>         *(.rodata)
>         *(.rodata.*)
> +
> +#ifdef LOCK_PROFILE
> +       __lock_profile_start = .;
> +       *(.lockprofile.data)
> +       __lock_profile_end = .;
> +#endif
>    } :text
>  
>    . = ALIGN(SMP_CACHE_BYTES);
> @@ -97,13 +103,6 @@ SECTIONS
>         CONSTRUCTORS
>    } :text
>  
> -#ifdef LOCK_PROFILE
> -  . = ALIGN(32);
> -  __lock_profile_start = .;
> -  .lockprofile.data : { *(.lockprofile.data) } :text
> -  __lock_profile_end = .;
> -#endif

As I've said on a different patch of yours where you also moved
stuff around - an alignment of 32 is not needed here, but completely
dropping the ALIGN() is wrong, since __lock_profile_start may end
up misaligned (and not on the start of the first .lockprofile.data
section).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel