Re: [Xen-devel] staging: libxl compile error in libxl__domain_save

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/02/16 15:47, Wei Liu wrote:
> On Sun, Feb 28, 2016 at 10:39:17AM +0100, Olaf Hering wrote:
>> On Sat, Feb 27, Olaf Hering wrote:
>>
>>> -O2 -Wall
>>> -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
>> I think the cause is the lack of a "maintainer mode", which should
>> enable realworld CFLAGS. Either a new configure knob gets added (and
>> used!) or the existing EXTRA_CFLAGS_* have to be used by commiters. See
>> "grep EXTRA_CFLAGS INSTALL".
>>
> If the current set of compiler flags is not good enough, we should
> improve it. I'm afraid having a third set of maintainer mode flags that
> nobody else uses is going to cause us more headache.

We should be using system-provided CFLAGS/LDFLAGS for all userspace,
appending our own local ones as appropriate.  Anything else is (as
demonstrated here) utterly fragile.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel